-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote OnClusterBuild featuregate to default #2192
base: master
Are you sure you want to change the base?
Promote OnClusterBuild featuregate to default #2192
Conversation
Hello @yuqi-zhang! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuqi-zhang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Currently for testing |
Given the absence of automated testing reporting into component readiness, there is a want to make an exception for this feature and promote within 4.19 based on QE testing alone Could we please get a write up on this PR detailing the existing testing that QE have been completing, with links to historical pass rates where available I would also appreciate if we can link out to any trackers for the future automated regression testing that's in the pipeline |
Verify failure in schema checker is an issue with the alpha API, we will override that issue /test e2e-aws-ovn-hypershift |
@yuqi-zhang @cheesesashimi The failures in the minor upgrade look like they are legitimate, can you please investigate? |
244a7dc
to
c939ea4
Compare
Rebased on master just in case. It looks like in the failed upgrade, the MCO hasn't started upgrade yet (?) and the operator logs are failing on:
checking if that was caused by outdated CRDs. The kube-rbac-proxy failures should also be old, since the pods should have the proper SCC labels now |
/retest |
@yuqi-zhang: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
These jobs are currently impacted by this issue: OCPBUGS-53408 In OCL. error: Old and new refs are equal
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-tp-ocl-f7 An OCL cluster does not behave exactly the same as a non-OCL cluster, so some test cases may fail in an OCL cluster because of that. Especially the ones that scale up new nodes (OCL needs an extra reboot) or configure registries.conf (OCL clusters reboot the nodes but non-OCL cluster don't do it)
Same case as above, since an OCL cluster doesn't behave exactly as a non-OCL cluster some cases will never pass. Especially the test cases involving scaling up new nodes (OCL needs an extra reboot to apply the new image), and those configuring the registres.conf file (OCL clusters reboots the nodes in this scenario, but non-OCL clusters do not reboot the nodes).
These jobs have been reconfigured to run daily IPI on GCP, AMD64,TP IPI on AWS, ARM64,PROXY,FIPS,TP These jobs are currently impacted by OCPBUGS-49894 In OCL. Disabling OCL process is not working in clusters with proxy Unfortunately this issue breaks the cluster and we cannot recover it, so once our tests hit this issue all tests will report failures or refuse to be executed. I have just launched all the jobs with the latest nightly build. |
Final step to GA On Cluster Layering, after
openshift/machine-config-operator#4756 and #2134
See also updated enhancement: openshift/enhancements#1515